Skip to content

Conversation

zwatson2001
Copy link
Collaborator

This PR closes #369, adding a fallback image in case the required image is not found (a short term fix for Colombia). I added this for the hardcoded images that are not in the task corpora, since any missing corpus images would cause the validation to fail and end the task with an error.

@asengupta3
Copy link
Collaborator

I don't know if this solves the underlying of issue. Because what you are checking for is, if the key exists in the mediaAssets object. Which, it should otherwise the first validation test we run will fail. Most likely this is happening because the buckets are having the CORS issue (I can see that in a number of trials even now). In that scenario, this PR won't help. Let me think through this a bit and let's discuss a plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] User feedback when image not found
2 participants